[PhpUnitBridge] Replace calls to setExpectedException by Pollyfill #32872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Aug 1, 2019
jderusse
force-pushed
the
compat-phpunit9-setExpectedException
branch
from
87220e4
to
5df9fef
Compare
nicolas-grekas
force-pushed
the
compat-phpunit9-setExpectedException
branch
from
5df9fef
to
3074265
Compare
jderusse
force-pushed
the
compat-phpunit9-setExpectedException
branch
from
3074265
to
41c02d7
Compare
maxhelias
approved these changes
Aug 1, 2019
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 1, 2019
…usse) This PR was merged into the 3.4 branch. Discussion ---------- Replace calls to setExpectedException by Pollyfill | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | need #32869 to be merged | Fixed tickets | #32844 | License | MIT | Doc PR | NA PhpUnit method `setExceptionException` has been deprecated seens 5.7. This PR replace theme by `exceptException` provide by the pollyfill. Commits ------- 41c02d7 Replace calls to setExpectedException by Pollyfill
Tobion
reviewed
Aug 2, 2019
| 'InvalidArgumentException', | ||
| 'You cannot refresh a user from the EntityUserProvider that does not contain an identifier. The user object has to be serialized with its own identifier mapped by Doctrine' | ||
| ); | ||
| $this->expectException('InvalidArgumentException'); |
There was a problem hiding this comment.
we should use ::class constant wherever we update this. best opportunity yet.
jderusse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpUnit method
setExceptionExceptionhas been deprecated seens 5.7. This PR replace theme byexceptExceptionprovide by the pollyfill.