[5.0] [Translator] Add parameter type-hints where possible #32218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matts
changed the title
57 tasks
derrabus
requested changes
Jun 27, 2019
Matts
changed the title
fabpot
approved these changes
Jul 5, 2019
fabpot
force-pushed
the
improvement/translator-type-hints
branch
from
3cab655
to
470996f
Compare
|
Thank you @Matts. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
…le (Matts) This PR was squashed before being merged into the 5.0-dev branch (closes #32218). Discussion ---------- [5.0] [Translator] Add parameter type-hints where possible | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Adding scalar typehints in Translator. Commits ------- 470996f [5.0] [Translator] Add parameter type-hints where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding scalar typehints in Translator.