[5.0] [WebProfilerBundle] Add parameter type-hints where possible #32216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matts
force-pushed
the
improvement/profiler-type-hints
branch
from
15a7e8e
to
0199b01
Compare
stof
requested changes
Jun 27, 2019
Matts
force-pushed
the
improvement/profiler-type-hints
branch
3 times, most recently
from
8081263
to
eeffb72
Compare
Matts
changed the title
derrabus
requested changes
Jun 27, 2019
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
57 tasks
Matts
force-pushed
the
improvement/profiler-type-hints
branch
from
eeffb72
to
8f33c6f
Compare
Matts
changed the title
fabpot
approved these changes
Jul 5, 2019
|
Thank you @Matts. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
… possible (Matts) This PR was merged into the 5.0-dev branch. Discussion ---------- [5.0] [WebProfilerBundle] Add parameter type-hints where possible | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Add type-hints for WebProfilerBundle in 5.0 Commits ------- 8f33c6f [WebProfilerBundle] Use scalar type-hints where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type-hints for WebProfilerBundle in 5.0