Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct dependencies on doctrine/common #28038

Merged
merged 1 commit into from Aug 1, 2018
Merged

Remove direct dependencies on doctrine/common #28038

merged 1 commit into from Aug 1, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Resubmitting #27609 now that Doctrine should be deprecation free.

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 23, 2018
@lyrixx
Copy link
Member

lyrixx commented Jul 23, 2018 


Testing src/Symfony/Bridge/Doctrine
...............................................................  63 / 234 ( 26%)
............................................................... 126 / 234 ( 53%)
............................S.................................. 189 / 234 ( 80%)
.............................................                   234 / 234 (100%)
Time: 2.27 seconds, Memory: 26.00MB
OK, but incomplete, skipped, or risky tests!
Tests: 234, Assertions: 484, Skipped: 1.
Remaining deprecation notices (1)
  1x: Doctrine\Common\ClassLoader is deprecated.
    1x in EntityTypeTest::setUp from Symfony\Bridge\Doctrine\Tests\Form\Type

@nicolas-grekas
Copy link
Member Author

Needs doctrine/orm#7307 to be merged into doctrine/orm 2.7.

@nicolas-grekas
Copy link
Member Author

Thank you @Majkl578.

@nicolas-grekas nicolas-grekas merged commit cb91cde into symfony:master Aug 1, 2018
nicolas-grekas added a commit that referenced this pull request Aug 1, 2018
@nicolas-grekas
minor #28038 Remove direct dependencies on doctrine/common (Majkl578)
7fd8e98 
This PR was merged into the 4.2-dev branch.

Discussion
----------

Remove direct dependencies on doctrine/common

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Resubmitting #27609 now that Doctrine should be deprecation free.

Commits
-------

cb91cde Remove direct dependencies on doctrine/common
@nicolas-grekas nicolas-grekas deleted the doctrine-no-common branch August 1, 2018 16:13
@fmonts
Copy link

fmonts commented Aug 29, 2018

The deprecation warning is still present in Symfony 4.1.4, when will it be fixed?

@xabbuh
Copy link
Member

xabbuh commented Sep 3, 2018

@fmonts This is caused by doctrine/orm not having a fix released yet for some code that triggers this (see #28119 for more information).

@bobdenotter bobdenotter mentioned this pull request Sep 4, 2018
Closed
@stof
Copy link
Member

stof commented Sep 4, 2018

@fmonts the deprecation is not in Symfony at all. It is between doctrine/common and doctrine/orm

@symfony symfony locked and limited conversation to collaborators Sep 4, 2018
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egircys egircys egircys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nicolas-grekas @lyrixx @fmonts @xabbuh @stof @egircys @carsonbot @Majkl578