Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer update + leverage symfony/flex ~1.1 #854

Closed
wants to merge 1 commit into from
Closed

Composer update + leverage symfony/flex ~1.1 #854

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

No description provided.

@javiereguiluz
Copy link
Member

Nicolas, I'm sorry but merging other pending PRs introduced conflicts in this one. Can you please take a look? Thanks!

@bobdenotter
Copy link
Contributor

bobdenotter commented Sep 4, 2018 •
edited

This PR will also fail tests, because when the doctrine/* packages get updated, you'll bump into the same issue as I did in #846 :

PHPUnit 6.5.11 by Sebastian Bergmann and contributors.

Testing Project Test Suite
..................................................                50 / 50 (100%)

Time: 1.03 minutes, Memory: 56.25MB

OK (50 tests, 92 assertions)

Remaining deprecation notices (1)

  1x: Doctrine\Common\ClassLoader is deprecated.
    1x in BlogControllerTest::testAdminBackendHomePage from App\Tests\Controller\Admin

I think we need to either selectively update symfony/* components, or lock the versions of doctrine/*, or do something similar as you did in symfony/symfony#28038

@stof
Copy link
Member

stof commented Sep 4, 2018

The drawback of using * as Symfony constraint is that composer validate now complains about using unbounded constraint (and it is perfectly right about it).
Thus, any time you use composer require for new components, they would still get an actual constraint (unless you explicitly force *, but then you're responsible for the unbounded constraint).
I suggest keeping bound constraints.

@bobdenotter bobdenotter mentioned this pull request Sep 6, 2018
Closed
@nicolas-grekas nicolas-grekas deleted the composer-up branch September 6, 2018 11:05
javiereguiluz added a commit that referenced this pull request Sep 7, 2018
@javiereguiluz
feature #855 Updating composer deps, don't fail tests on vendor depre…
c8ba26c 
…cations (bobdenotter)

This PR was squashed before being merged into the master branch (closes #855).

Discussion
----------

Updating composer deps, don't fail tests on vendor deprecations

Follows #846, replaces #854

I've taken the liberty of updating @nicolas-grekas' PR to update flex to 1.1, whilst keeping bound constraints for the symfony components.

Tests would fail on a deprecation in doctrine/common. I have also added a temporary `SYMFONY_DEPRECATIONS_HELPER=weak_vendors`, so it'll pass tests. After Symfony 4.2 has been released, I'll remove it.

Commits
-------

bbe1e49 Updating composer deps, don't fail tests on vendor deprecations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolas-grekas @javiereguiluz @bobdenotter @stof