[Intl] Add compile binary #30584
Merged
[Intl] Add compile binary #30584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Mar 16, 2019
fabpot
approved these changes
Mar 17, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Add compile binary | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no-ish | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from #28831) ```bash $ src/Symfony/Component/Intl/Resources/bin/compile ``` run in repository root because of https://github.com/symfony/symfony/blob/b7e798ef745a09ca2e76fba4afad0a04fcbd9195/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php#L141 3.4 is ok, 4.2 is not because of #28833 but new locales are introduced in https://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1 So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run `compile` (potential for automating, but run if needed :)) Commits ------- 426b92f [Intl] Add compile binary
Merged
fabpot
added a commit
that referenced
this pull request
Mar 17, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [Intl][4.2] Fix test | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Related to #30584 , the tests we're missing updated fixtures. My bad also 😅 Now fixed, while at it recompiled intl for 4.2 ✌️ Commits ------- 50b52cf [Intl][4.2] Fix test
fabpot
added a commit
that referenced
this pull request
Mar 30, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Simplify the compile binary | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | - The intl docker image comes with build-essential packages now, so there's no need for additional installation steps. re #30584 Commits ------- b3184c2 [Intl] Simplify the compile binary
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from #28831)
run in repository root because of
symfony/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php
Line 141 in b7e798e
3.4 is ok, 4.2 is not because of #28833 but new locales are introduced in https://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1
So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run
compile(potential for automating, but run if needed :))