Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Simplify the compile binary #30778

Merged
merged 1 commit into from Mar 30, 2019
Merged

[Intl] Simplify the compile binary #30778

merged 1 commit into from Mar 30, 2019

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Mar 29, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The intl docker image comes with build-essential packages now, so there's no need for additional installation steps.

re #30584

                         The docker image comes with the build-essential packages now.
@fabpot
Copy link
Member

fabpot commented Mar 30, 2019

Thank you @jakzal.

@fabpot fabpot merged commit b3184c2 into symfony:3.4 Mar 30, 2019
fabpot added a commit that referenced this pull request Mar 30, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] Simplify the compile binary

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The intl docker image comes with build-essential packages now, so there's no need for additional installation steps.

re #30584

Commits
-------

b3184c2 [Intl] Simplify the compile binary
@jakzal jakzal deleted the intl-compile branch March 30, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants