Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl][4.2] Fix test #30588

Merged
merged 1 commit into from Mar 17, 2019
Merged

[Intl][4.2] Fix test #30588

merged 1 commit into from Mar 17, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Mar 17, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Related to #30584 , the tests we're missing updated fixtures. My bad also 馃槄

Now fixed, while at it recompiled intl for 4.2 鉁岋笍

@ro0NL ro0NL changed the base branch from master to 4.2 March 17, 2019 09:38
@fabpot
Copy link
Member

fabpot commented Mar 17, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 50b52cf into symfony:4.2 Mar 17, 2019
fabpot added a commit that referenced this pull request Mar 17, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

[Intl][4.2] Fix test

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Related to #30584 , the tests we're missing updated fixtures. My bad also 馃槄

Now fixed, while at it recompiled intl for 4.2 鉁岋笍

Commits
-------

50b52cf [Intl][4.2] Fix test
@ro0NL ro0NL deleted the intl-tests branch March 17, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants