Skip to content

Commit

Permalink
bug #29764 [HttpFoundation] Check file exists before unlink (adam-mos…
Browse files Browse the repository at this point in the history
…pan)

This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29764).

Discussion
----------

[HttpFoundation] Check file exists before unlink

Check file exists to prevent ErrorException

| Q             | A
| ------------- | ---
| Branch?       | 2.6 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

1954187 [HttpFoundation] Check file exists before unlink
  • Loading branch information
nicolas-grekas committed Jan 25, 2019
2 parents a1a3ffc + 1954187 commit afb7bb5
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -305,7 +305,7 @@ public function sendContent()
fclose($out);
fclose($file);

if ($this->deleteFileAfterSend) {
if ($this->deleteFileAfterSend && file_exists($this->file->getPathname())) {
unlink($this->file->getPathname());
}

Expand Down

0 comments on commit afb7bb5

Please sign in to comment.