Skip to content

Commit

Permalink
bug #29783 [HttpFoundation] MemcachedSessionHandler::close() must clo…
Browse files Browse the repository at this point in the history
…se connection (grachevko)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] MemcachedSessionHandler::close() must close connection

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

Intoduced here #3333

Commits
-------

38a9d8b [Bugfix] MemcachedSessionHandler::close() must close connection
  • Loading branch information
nicolas-grekas committed Jan 25, 2019
2 parents 46ebf23 + 38a9d8b commit a1a3ffc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Expand Up @@ -62,7 +62,7 @@ public function __construct(\Memcached $memcached, array $options = [])
*/
public function close()
{
return true;
return $this->memcached->quit();
}

/**
Expand Down
Expand Up @@ -63,6 +63,12 @@ public function testOpenSession()

public function testCloseSession()
{
$this->memcached
->expects($this->once())
->method('quit')
->will($this->returnValue(true))
;

$this->assertTrue($this->storage->close());
}

Expand Down

0 comments on commit a1a3ffc

Please sign in to comment.