add alternative method for symfony/flex #17031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
add-alternative-method-for-symfony/flex
branch
from
88f2198
to
66a7abb
Compare
alexislefebvre
force-pushed
the
add-alternative-method-for-symfony/flex
branch
from
66a7abb
to
ab05025
Compare
|
I'm not for nor against this way of testing a bundle with a specific Symfony version. But for a best practice it would be better IMHO to only suggest one way of doing the same thing (testing a bundle with a specific Symfony version) and not 2 alternative ways. |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Aug 5, 2022
This PR was merged into the 4.x branch. Discussion ---------- add symfony/flex to require-dev Follow-up of #5330 There's no need to require `symfony/flex` on the CI, it can be added to `required-dev`. This is the same idea than symfony/symfony-docs#17031 Commits ------- e07ff0b add symfony/flex to require-dev
|
This was a bad idea, don't do that in a bundle, see EasyCorp/EasyAdminBundle#5354 for the consequences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose another way to use `symfony/flex/ in a bundle:
symfony/flexas a dependency of the project, not only on the CIcomposer config …instead of relying on a variable (it's more consistent in my humble opinion)Source: shivammathur/setup-php#611 (comment)
This way may also replace the previous block.