add symfony/flex to require-dev #5346
Conversation
|
@alexislefebvre Isn't there a small difference?
(What do you mean with #17031 ?) |
|
@michaelKaefer this is right, I propose to require it so that it doesn't need to be written 7 times for the workflows. I fixed the link. |
|
@alexislefebvre Thanks for the link, ok I see, this PR could be merged if it becomes best practice. |
|
I don't have a strong opinion about this ... but I've decided to merge it. Please note that I moved the |
To address your remark: this is true, yet I think there's no downside to require it as a
Oops! I screwed up, thanks for fixing it. |
I was so wrong, |
…bvre) This PR was squashed before being merged into the 4.x branch. Discussion ---------- Remove symfony/flex from composer require dev With the changes from #5346, cloning this project and running `composer install` will run the recipes from Symfony, it will add many files that we don't want: ```bash $ composer install […] $ git status On branch 4.x Your branch is up to date with 'origin/4.x'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: .gitignore modified: composer.json modified: phpunit.xml.dist Untracked files: (use "git add <file>..." to include in what will be committed) .env .env.test bin/ config/ docker-compose.override.yml docker-compose.yml public/ src/Controller/.gitignore src/DataFixtures/ src/Entity/ src/Kernel.php src/Repository/ symfony.lock templates/ translations/ ``` This PR revert this. I apologize, I should have tested that before assuming that `symfony/flex` would not intervene. Commits ------- 3131083 Remove symfony/flex from composer require dev
Follow-up of #5330
There's no need to require
symfony/flexon the CI, it can be added torequired-dev.This is the same idea than symfony/symfony-docs#17031