Fix CI for php 8 #301
Merged
Fix CI for php 8 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll find some thoughts at #247 |
|
@nicolas-grekas I‘d like to get to the point that we can actually solve #247. Right now, the nightly run ist just plain dead. :-/ |
|
Let's wait for #303. |
Merged
derrabus
force-pushed
the
improvement/php8ci
branch
from
8973635
to
92f299c
Compare
|
I've rebased the PR on #303. |
derrabus
force-pushed
the
improvement/php8ci
branch
from
92f299c
to
49b402c
Compare
|
Current state of the PR: The tests should run on php 8 with PHPUnit 9.4. Forget what I wrote. We should fix that listener. |
derrabus
commented
Oct 23, 2020
derrabus
force-pushed
the
improvement/php8ci
branch
from
49b402c
to
2212147
Compare
|
🤞🏻 The listener should work now. |
derrabus
force-pushed
the
improvement/php8ci
branch
from
2212147
to
c590cdb
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2020
This PR was merged into the 1.20-dev branch. Discussion ---------- GitHub Actions This PR ports our CI to GitHub Actions. While Travis still considers if it should boot the VMs for our CI, the run on GH Actions has been completed already. * This PR includes #303, so please ignore the first commit when reviewing * The PHP 8 run fails (as it does on Travis). I'll try to resolve this in #301. Commits ------- dd2e19f GitHub Actions
nicolas-grekas
force-pushed
the
improvement/php8ci
branch
from
c590cdb
to
7fdf16f
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests currently don't work on php 8. I'd like to give it a try to fix this.