Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions #305

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Oct 23, 2020

This PR ports our CI to GitHub Actions. While Travis still considers if it should boot the VMs for our CI, the run on GH Actions has been completed already.

@derrabus
Copy link
Member Author

GH Actions seem to be disabled on this repo. Here's the latest run on my fork: https://github.com/derrabus/polyfill/runs/1298646165

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

Dunno why they didn't run. Settings tell they are enabled.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@stof
Copy link
Member

stof commented Oct 23, 2020

Dunno why they didn't run. Settings tell they are enabled.

IIRC, the workflow files need to be present in the target branch to allow the job to run. A PR adding the CI workflow won't trigger it.

.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@derrabus
Copy link
Member Author

IIRC, the workflow files need to be present in the target branch to allow the job to run. A PR adding the CI workflow won't trigger it.

Oh my. Well then, you can click on derrabus:improvement/gh-actions at the top of this page to see the latest run.

@stof
Copy link
Member

stof commented Oct 23, 2020

The failure on PHP 8 is because it installs PHPUnit 9.3 which is not yet supported by the bridge (I think 5.2-dev supports it but I'm not sure). Travis was forcing SYMFONY_PHPUNIT_VERSION=7.2

@derrabus
Copy link
Member Author

derrabus commented Oct 23, 2020

The failure on PHP 8 is because it installs PHPUnit 9.3 which is not yet supported by the bridge (I think 5.2-dev supports it but I'm not sure).

PhpUnitBridge 5.2-dev is actually being used. That's why we get PHPUnit 9.3 in the first place.

The listener is the problem. (edit: actually the test listener of the polyfills, not the bridge)

Travis was forcing SYMFONY_PHPUNIT_VERSION=7.2

Yes, but Nicolas' PR removes that already. PHPUnit 7.2 won't work either because it is not compatible with PHP 8.

@derrabus derrabus force-pushed the improvement/gh-actions branch 4 times, most recently from 8c56510 to af89192 Compare October 23, 2020 22:40
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 184bc04 into symfony:main Oct 24, 2020
@derrabus derrabus deleted the improvement/gh-actions branch October 24, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants