-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions #305
GitHub Actions #305
Conversation
GH Actions seem to be disabled on this repo. Here's the latest run on my fork: https://github.com/derrabus/polyfill/runs/1298646165 |
Dunno why they didn't run. Settings tell they are enabled. |
718498a
to
dae0664
Compare
IIRC, the workflow files need to be present in the target branch to allow the job to run. A PR adding the CI workflow won't trigger it. |
Oh my. Well then, you can click on |
The failure on PHP 8 is because it installs PHPUnit 9.3 which is not yet supported by the bridge (I think 5.2-dev supports it but I'm not sure). Travis was forcing |
dae0664
to
103840c
Compare
PhpUnitBridge 5.2-dev is actually being used. That's why we get PHPUnit 9.3 in the first place. The listener is the problem. (edit: actually the test listener of the polyfills, not the bridge)
Yes, but Nicolas' PR removes that already. PHPUnit 7.2 won't work either because it is not compatible with PHP 8. |
8c56510
to
af89192
Compare
af89192
to
dd2e19f
Compare
Thank you @derrabus. |
This PR ports our CI to GitHub Actions. While Travis still considers if it should boot the VMs for our CI, the run on GH Actions has been completed already.