[WIP] Fix failing tests #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents our tests failing while Symfony uses a deprecated call from doctrine/common
|
Which failing test? Which deprecation? |
|
The root issue is fixed in doctrine/orm#7307, which will be part of doctrine/orm v2.6.3 |
|
Ah, I thought we needed to wait until Symfony 4.2 for the deprecation to be removed. Let's close and ignore the deprecation until 2.6.3 is out. Thanks :) |
weaverryan
added a commit
that referenced
this pull request
Sep 6, 2018
… pass (weaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- Working around deprecation errors to get the test suite to pass This is a repeat of #237. The tests have been failing for too long. I think we need to fix them, and then we can revert later when doctrine/orm v2.6.3 is released. Cheers! Commits ------- b3706d4 Working around deprecation errors to get the test suite to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress deprecated doctrine class error