Skip to content

Commit

Permalink
minor #259 Working around deprecation errors to get the test suite to…
Browse files Browse the repository at this point in the history
… pass (weaverryan)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Working around deprecation errors to get the test suite to pass

This is a repeat of #237. The tests have been failing for too long. I think we need to fix them, and then we can revert later when doctrine/orm v2.6.3 is released.

Cheers!

Commits
-------

b3706d4 Working around deprecation errors to get the test suite to pass
  • Loading branch information
weaverryan committed Sep 6, 2018
2 parents 9ec8b5e + b3706d4 commit 70bbe65
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions phpunit.xml.dist
Expand Up @@ -10,6 +10,8 @@
<php>
<ini name="error_reporting" value="-1" />
<env name="TEST_DATABASE_DSN" value="mysql://root:@127.0.0.1:3306/test_maker" />
<!-- See #237 -->
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
</php>

<testsuites>
Expand Down
9 changes: 9 additions & 0 deletions src/Test/MakerTestEnvironment.php
Expand Up @@ -338,6 +338,15 @@ private function buildFlexSkeleton()
MakerTestProcess::create('composer require phpunit browser-kit symfony/css-selector', $this->flexPath)
->run();

// temporarily ignoring indirect deprecations - see #237
$replacements = [
[
'filename' => 'phpunit.xml.dist',
'find' => '</php>',
'replace' => ' <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />'."\n".' </php>',
],
];

MakerTestProcess::create('php bin/console cache:clear --no-warmup', $this->flexPath)
->run();
}
Expand Down

0 comments on commit 70bbe65

Please sign in to comment.