Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose MountFUSE / UnmountFUSE API #209

Merged
merged 1 commit into from Apr 22, 2022
Merged

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Apr 19, 2022

Move Mount and Unmount to pkg from internal.

Rename to xxxxFUSE to make it clear these are FUSE mounts, rather than anything else.

Fixes #206

@dtrudg dtrudg self-assigned this Apr 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #209 (7c54475) into master (3e8948f) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 7c54475 differs from pull request most recent head 1ab2364. Consider uploading reports for the commit 1ab2364 to get more accurate results

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   73.28%   73.28%           
=======================================
  Files          34       34           
  Lines        2650     2650           
=======================================
  Hits         1942     1942           
  Misses        567      567           
  Partials      141      141           
Impacted Files Coverage Δ
internal/app/siftool/mount.go 0.00% <0.00%> (ø)
internal/app/siftool/unmount.go 0.00% <0.00%> (ø)
pkg/sif/mount.go 0.00% <0.00%> (ø)
pkg/sif/unmount.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8948f...1ab2364. Read the comment docs.

Move `Mount` and `Unmount` to `pkg` from `internal`.

Rename to `xxxxFUSE` to make it clear these are FUSE mounts, rather
than anything else.

Fixes sylabs#206
@dtrudg dtrudg marked this pull request as ready for review April 20, 2022 21:19
@dtrudg dtrudg requested a review from tri-adam April 20, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Mount / Umount into pkg for consumption by Singularity
3 participants