Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif through v2.7.0 #10

Closed
wants to merge 14 commits into from
Closed

Merge sylabs/sif through v2.7.0 #10

wants to merge 14 commits into from

Conversation

Adam Hughes and others added 8 commits April 20, 2022 14:21
Use valid squashfs/ext3 inputs when generating test images. Update test
corpus. Update golden files to correspond to test corpus.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Add experimental support for rootless mount of SIF images.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
…3124808-70ae35bab23f to v0.0.0-20220407094043-a94812496cf5

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Remove magefiles and update CI config to use Go tooling natively.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #10 (97c1e2b) into master (5579b98) will decrease coverage by 0.18%.
The diff coverage is 58.06%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   76.46%   76.28%   -0.19%     
==========================================
  Files          28       30       +2     
  Lines        2503     2534      +31     
==========================================
+ Hits         1914     1933      +19     
- Misses        450      461      +11     
- Partials      139      140       +1     
Flag Coverage Δ
unittests 76.28% <58.06%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/app/siftool/mount.go 0.00% <0.00%> (ø)
internal/app/siftool/app.go 65.21% <16.66%> (-17.14%) ⬇️
pkg/siftool/mount.go 72.72% <72.72%> (ø)
pkg/siftool/siftool.go 92.30% <100.00%> (+5.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5579b98...97c1e2b. Read the comment docs.

@edytuk edytuk requested a review from DrDaveD April 20, 2022 13:04
Copy link
Collaborator

@DrDaveD DrDaveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to leave this pending for a while. The experimental squashfuse stuff is entirely different from the way I have implemented it, and I expect it may go through some churn.

@edytuk edytuk closed this May 4, 2022
@edytuk edytuk reopened this May 5, 2022
@edytuk edytuk force-pushed the v2.5.0 branch 7 times, most recently from f979dbe to b7c4a96 Compare May 6, 2022 11:50
edytuk and others added 4 commits May 10, 2022 12:43
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Fixes sylabs/sif#204

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Counterpart to mount, will unmount a squashfuse mounted filesystem via
fusermount.

Fixes sylabs/sif#205

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Move `Mount` and `Unmount` to `pkg` from `internal`.

Rename to `xxxxFUSE` to make it clear these are FUSE mounts, rather
than anything else.

Fixes sylabs/sif#206

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@edytuk edytuk changed the title Merge sylabs/sif through v2.5.0 Merge sylabs/sif through v2.7.0 May 10, 2022
@edytuk edytuk requested a review from DrDaveD May 10, 2022 12:07
@edytuk edytuk closed this May 11, 2022
@edytuk edytuk deleted the v2.5.0 branch May 12, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants