Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif through v2.7.0 #138

Merged
merged 14 commits into from May 11, 2022
Merged

Merge sylabs/sif through v2.7.0 #138

merged 14 commits into from May 11, 2022

Conversation

Adam Hughes and others added 14 commits April 20, 2022 14:21
Use valid squashfs/ext3 inputs when generating test images. Update test
corpus. Update golden files to correspond to test corpus.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Add experimental support for rootless mount of SIF images.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
…3124808-70ae35bab23f to v0.0.0-20220407094043-a94812496cf5

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Remove magefiles and update CI config to use Go tooling natively.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Fixes sylabs/sif#204

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Counterpart to mount, will unmount a squashfuse mounted filesystem via
fusermount.

Fixes sylabs/sif#205

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Move `Mount` and `Unmount` to `pkg` from `internal`.

Rename to `xxxxFUSE` to make it clear these are FUSE mounts, rather
than anything else.

Fixes sylabs/sif#206

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@codecov-commenter
Copy link

Codecov Report

Merging #138 (42e4c74) into master (5579b98) will decrease coverage by 3.18%.
The diff coverage is 18.36%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   76.46%   73.28%   -3.19%     
==========================================
  Files          28       34       +6     
  Lines        2503     2650     +147     
==========================================
+ Hits         1914     1942      +28     
- Misses        450      567     +117     
- Partials      139      141       +2     
Flag Coverage Δ
unittests 73.28% <18.36%> (-3.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/app/siftool/mount.go 0.00% <0.00%> (ø)
internal/app/siftool/unmount.go 0.00% <0.00%> (ø)
pkg/user/mount.go 0.00% <0.00%> (ø)
pkg/user/unmount.go 0.00% <0.00%> (ø)
internal/app/siftool/app.go 65.21% <16.66%> (-17.14%) ⬇️
pkg/siftool/mount.go 72.72% <72.72%> (ø)
pkg/siftool/unmount.go 72.72% <72.72%> (ø)
pkg/siftool/siftool.go 92.50% <100.00%> (+5.83%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@DrDaveD DrDaveD merged commit 44d2d30 into apptainer:master May 11, 2022
@edytuk edytuk deleted the v2.5.0 branch May 12, 2022 08:40
@DrDaveD DrDaveD mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants