Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add experimental unmount command #208

Merged
merged 1 commit into from Apr 20, 2022
Merged

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Apr 18, 2022

Counterpart to mount, will unmount a squashfuse mounted filesystem via fusermount.

Fixes #205

@dtrudg dtrudg requested a review from tri-adam April 18, 2022 14:59
@dtrudg dtrudg self-assigned this Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #208 (037e00e) into master (5314bc0) will decrease coverage by 3.54%.
The diff coverage is 10.46%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   76.28%   72.73%   -3.55%     
==========================================
  Files          30       34       +4     
  Lines        2534     2670     +136     
==========================================
+ Hits         1933     1942       +9     
- Misses        461      587     +126     
- Partials      140      141       +1     
Impacted Files Coverage Δ
internal/app/siftool/unmount.go 0.00% <0.00%> (ø)
internal/pkg/exp/umount.go 0.00% <0.00%> (ø)
pkg/siftool/unmount.go 72.72% <72.72%> (ø)
pkg/siftool/siftool.go 92.50% <100.00%> (+0.19%) ⬆️
internal/pkg/exp/mount.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5314bc0...037e00e. Read the comment docs.

@dtrudg dtrudg force-pushed the issue205 branch 2 times, most recently from 4ebd8c7 to 561b25b Compare April 18, 2022 15:07
@dtrudg dtrudg marked this pull request as ready for review April 18, 2022 15:09
Copy link
Member

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions, thanks @dtrudg !

internal/pkg/exp/umount.go Outdated Show resolved Hide resolved
internal/pkg/exp/umount.go Outdated Show resolved Hide resolved
pkg/siftool/umount.go Outdated Show resolved Hide resolved
pkg/siftool/umount.go Outdated Show resolved Hide resolved
internal/pkg/exp/umount.go Outdated Show resolved Hide resolved
internal/pkg/exp/umount.go Outdated Show resolved Hide resolved
@dtrudg dtrudg force-pushed the issue205 branch 9 times, most recently from c04ff00 to 336e7f9 Compare April 19, 2022 20:10
@dtrudg dtrudg changed the title feat: Add experimental umount command feat: Add experimental unmount command Apr 19, 2022
@dtrudg dtrudg requested a review from tri-adam April 19, 2022 20:15
Copy link
Member

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just two more git mv for consistency:

  • internal/pkg/exp/umount.go -> internal/pkg/exp/unmount.go
  • internal/pkg/exp/umount_test.go -> internal/pkg/exp/unmount_test.go

Counterpart to mount, will unmount a squashfuse mounted filesystem via
fusermount.

Fixes sylabs#205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an Umount counterpart to Mount
3 participants