New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add experimental unmount command #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 76.28% 72.73% -3.55%
==========================================
Files 30 34 +4
Lines 2534 2670 +136
==========================================
+ Hits 1933 1942 +9
- Misses 461 587 +126
- Partials 140 141 +1
Continue to review full report at Codecov.
|
4ebd8c7
to
561b25b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions, thanks @dtrudg !
c04ff00
to
336e7f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just two more git mv
for consistency:
internal/pkg/exp/umount.go
->internal/pkg/exp/unmount.go
internal/pkg/exp/umount_test.go
->internal/pkg/exp/unmount_test.go
Counterpart to mount, will unmount a squashfuse mounted filesystem via fusermount. Fixes sylabs#205
Counterpart to mount, will unmount a squashfuse mounted filesystem via fusermount.
Fixes #205