Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: add option to specify squashfuse path #207

Merged
merged 1 commit into from Apr 19, 2022

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Apr 18, 2022

Fixes #204

@dtrudg dtrudg requested a review from tri-adam April 18, 2022 13:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #207 (5ad2b1e) into master (5314bc0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   76.28%   76.28%           
=======================================
  Files          30       30           
  Lines        2534     2534           
=======================================
  Hits         1933     1933           
  Misses        461      461           
  Partials      140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5314bc0...5ad2b1e. Read the comment docs.

@dtrudg dtrudg marked this pull request as draft April 18, 2022 14:02
@dtrudg dtrudg force-pushed the issue204 branch 2 times, most recently from fa30084 to b4a6c32 Compare April 18, 2022 15:04
@dtrudg dtrudg marked this pull request as ready for review April 18, 2022 15:08
Copy link
Member

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a few small changes please and thank you.

internal/pkg/exp/mount.go Outdated Show resolved Hide resolved
internal/pkg/exp/mount.go Outdated Show resolved Hide resolved
internal/pkg/exp/mount.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount should accept a path to squashfuse
3 participants