Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(preset_env_base): remove serde-serialize from bindgen #6485

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 16 additions & 15 deletions crates/preset_env_base/Cargo.toml
@@ -1,23 +1,24 @@
[package]
authors = ["강동윤 <kdy1997.dev@gmail.com>"]
description = "Common logic for targetting vairous browsers"
authors = ["강동윤 <kdy1997.dev@gmail.com>"]
description = "Common logic for targetting vairous browsers"
documentation = "https://rustdoc.swc.rs/preset_env_base/"
edition = "2021"
license = "Apache-2.0"
name = "preset_env_base"
version = "0.3.2"
edition = "2021"
license = "Apache-2.0"
name = "preset_env_base"
version = "0.3.2"

[lib]
bench = false

[dependencies]
ahash = "0.7.4"
ahash = "0.7.4"
anyhow = "1"
browserslist-rs = "=0.11.0"
dashmap = "5.1.0"
from_variant = { version = "0.1.3", path = "../from_variant" }
once_cell = "1.12.0"
semver = { version = "1.0.4", features = ["serde"] }
serde = { version = "1", features = ["derive"] }
st-map = "0.1.2"
tracing = { version = "0.1.32" }
# https://github.com/browserslist/browserslist-rs/pull/13
browserslist-rs = { git = "https://github.com/kwonoj/browserslist-rs", rev = "bd47b8e17c937d15ed75fe9c3522ef0ac94ffcd9" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will block publishing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I keep forgetting it 🤦 . Guess this is no go and I have to wait browserslist/browserslist-rs#13?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing for now. as we can't ship it this anyway.

dashmap = "5.1.0"
from_variant = { version = "0.1.3", path = "../from_variant" }
once_cell = "1.12.0"
semver = { version = "1.0.4", features = ["serde"] }
serde = { version = "1", features = ["derive"] }
st-map = "0.1.2"
tracing = { version = "0.1.32" }