refactor(preset_env_base): remove serde-serialize from bindgen #6485
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Nov 20, 2022
| st-map = "0.1.2" | ||
| tracing = { version = "0.1.32" } | ||
| # https://github.com/browserslist/browserslist-rs/pull/13 | ||
| browserslist-rs = { git = "https://github.com/kwonoj/browserslist-rs", rev = "bd47b8e17c937d15ed75fe9c3522ef0ac94ffcd9" } |
There was a problem hiding this comment.
ah, I keep forgetting it 🤦 . Guess this is no go and I have to wait browserslist/browserslist-rs#13?
There was a problem hiding this comment.
Closing for now. as we can't ship it this anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Same as #6462, but for the transitive dep browserslist-rs. There is an open PR targeting the latest version of browserslist (0.12), but we are currently using 0.11 so use a commit kwonoj/browserslist-rs@bd47b8e#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R58 to safely remove features for now, and then later try to bump up version separately to avoid regressions.
BREAKING CHANGE:
Related issue (if exists):