build(deps): bump @xmldom/xmldom from 0.8.8 to 0.8.10

[dependabot]

Bumps @xmldom/xmldom from 0.8.8 to 0.8.10.

Release notes

Sourced from @​xmldom/xmldom's releases.

0.8.10

Commits

Fixed

• dom: prevent iteration over deleted items [#514](https://github.com/xmldom/xmldom/issues/514)/ [#499](https://github.com/xmldom/xmldom/issues/499)

Thank you, @​qtow, for your contributions

0.8.9

Commits

Fixed

• Set nodeName property in ProcessingInstruction [#509](https://github.com/xmldom/xmldom/issues/509) / [#505](https://github.com/xmldom/xmldom/issues/505)

Thank you, @​cjbarth, for your contributions

Changelog

Sourced from @​xmldom/xmldom's changelog.

0.8.10

Fixed

• dom: prevent iteration over deleted items [#514](https://github.com/xmldom/xmldom/issues/514)/ [#499](https://github.com/xmldom/xmldom/issues/499)

Thank you, @​qtow, for your contributions

0.7.13

Fixed

• dom: prevent iteration over deleted items [#514](https://github.com/xmldom/xmldom/issues/514)/ [#499](https://github.com/xmldom/xmldom/issues/499)

Thank you, @​qtow, for your contributions

0.9.0-beta.9

Fixed

• Set nodeName property in ProcessingInstruction [#509](https://github.com/xmldom/xmldom/issues/509) / [#505](https://github.com/xmldom/xmldom/issues/505)
• preserve DOCTYPE internal subset [#498](https://github.com/xmldom/xmldom/issues/498) / [#497](https://github.com/xmldom/xmldom/issues/497) / [#117](https://github.com/xmldom/xmldom/issues/117)
  BREAKING CHANGES: Many documents that were previously accepted by xmldom, esecially non well-formed ones are no longer accepted. Some issues that were formerly reported as errors are now a fatalError.
• DOMParser: Align parseFromString errors with specs [#454](https://github.com/xmldom/xmldom/issues/454)

Chore

• stop running mutation tests using stryker [#496](https://github.com/xmldom/xmldom/issues/496)
• make toErrorSnapshot windows compatible [#503](https://github.com/xmldom/xmldom/issues/503)

Thank you, @​cjbarth, @​shunkica, @​pmahend1, @​niklasl, for your contributions

0.8.9

Fixed

• Set nodeName property in ProcessingInstruction [#509](https://github.com/xmldom/xmldom/issues/509) / [#505](https://github.com/xmldom/xmldom/issues/505)

Thank you, @​cjbarth, for your contributions

0.7.12

Fixed

• Set nodeName property in ProcessingInstruction [#509](https://github.com/xmldom/xmldom/issues/509) / [#505](https://github.com/xmldom/xmldom/issues/505)

... (truncated)

Commits

• 252395e 0.8.10
• 00c683e fix(dom): prevent iteration over deleted items (#514)
• b87f2bd 0.8.9
• efac66a fix: Set nodeName property in ProcessingInstruction (#509)
• See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[Kreeg]

Idk how bug fixes in xmldom changed all the snapshots. Seems like a regression bug

[XhmikosR]

This broke completely svg-sprite for us on bootstrap icons. I had to pin xmldom to v0.8.8. I will pin it in this repo later too.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

[XhmikosR]

Reported this in xmldom/xmldom#583

[Ingramz]

Here's a patch for 3.0.0-beta2 that worked around this issue by reverting part of #591. I fixed this in one of my personal projects but due to lack of time never get to reporting this as a bug. Seeing 3.0.0-beta3 coming out made me look here.

Hopefully it will be of help when investigating which project is at fault here.

svg-sprite+3.0.0-beta2.patch

[XhmikosR]

@Ingramz can you please make a PR?

[XhmikosR]

Our code is the same between the related xmldom versions, so while it could be something in our code, v0.8.8 works fine with it while 0.8.10 breaks.

[Ingramz]

I will a pull request based on this patch in a moment, but there are two caveats:

1. This is the bare minimum that fixed issues within my own project. I have not looked whether there are other places that would require a similar change. Any sort of tests and related ceremony I would leave up to others.
2. If it turns out that recent xmldom changes incorrectly broke the ability to use Object.keys(), then this pull request would not be needed and we should simply just wait for xmldom project to fix it. There is nothing wrong with staying at 0.8.8 for time being as it seems to solve this issue equally well.

[XhmikosR]

1. I tested your patch in bootstrap-icons that we hit the issue and it works. Also, tests in this repo passed
2. I agree, but I'm not sure at this point. I know for sure our code works with v0.8.8. That being said, it could be that the Object.keys change triggers some weird case like with null or undefined whereas plain for loops work

I say make a PR here with your changes and xmldom updated to 0.8.10 and unpinned and we see if we get a reply from the xmldom devs.