Replace iterating over Object.keys(NodeList) with NodeList.length
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seemingly fixes issues with xmldom versions greater than 0.8.8 & up to 0.8.10
XhmikosR
changed the title
Object.keys(NodeList) with NodeList.length
|
@Kreeg LGTY? It's weird that this caused all the issues but it should be fine, at least up until the xmldom devs respond to the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around xmldom versions greater than 0.8.8 & up to 0.8.10 seemingly not supporting use of Object.keys on NodeList to iterate over currently existing keys.
It should be noted I have not investigated whether
Object.keys(NodeList)is allowed per DOM specification and it could be that there exists a regression in xmldom. Track xmldom/xmldom#583 for relevant discussion.Original patch from #835 (comment)