Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] each animate allow having comment siblings #7435

Merged
merged 1 commit into from Apr 12, 2022

Conversation

tanhauhau
Copy link
Member

Similar to #7146, not quite sure why it was closed.

Fixing #3999

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@ghostdevv
Copy link
Member

I wonder who closed it 🤔

@benmccann
Copy link
Member

It's very weird it doesn't show who closed #7146. I've never seen that before

Co-authored-by: GHOST <ghostdevbusiness@gmail.com>
@tanhauhau
Copy link
Member Author

oh i think i know what happened, from the PR, @ghostdevv used the master branch. and probably the master branch got reset to svelte/master, so the commits are no longer there, and no more diff from svelte/master and ghostdevv/master, thus the PR got closed automatically

@tanhauhau tanhauhau merged commit d9687da into sveltejs:master Apr 12, 2022
@tanhauhau tanhauhau deleted the tanhauhau/gh-3999 branch April 12, 2022 08:48
@ghostdevv
Copy link
Member

Ah, my bad 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants