Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each blocks with animate don't account for "empty" children #7131

Closed
ghostdevv opened this issue Jan 13, 2022 · 3 comments
Closed

Each blocks with animate don't account for "empty" children #7131

ghostdevv opened this issue Jan 13, 2022 · 3 comments

Comments

@ghostdevv
Copy link
Member

ghostdevv commented Jan 13, 2022

Describe the bug

This issue is for tying together fixes and issues that would be closed when it's fixed so we can get this sorted

Currently a each block with a animate directive only allows for a single child, this check doesn't account for "empty" children, here I am defining a empty child as one that contains only tabs/line breaks/whitespaces

The issues presented below are essentially due to how the code author formats their dom, anything completely inline fixes all the issues below but when a author adds indentation/formatting to their code the each block detects as that a child despite it being "empty"

@ehrencrona Proposed a solution below which essentially filters through the children to remove the empty ones.

@tanhauhau posted a video on issue #5415 (which if fixed fixes the other issues) and his conclusion was a internal discussion needs to take place on how the whitespace is handled - but I am unsure what happened to this

Potential Fixes:

Issues closed by a fix occurring:
#3999 - Comments not allowed
#5415 - Inline each block believes it has multiple children [FIXED]
#7124 - {@const} tag causes each block to believe it has multiple children [FIXED]

Reproduction

See each issue linked above

Severity

annoyance

@ghostdevv
Copy link
Member Author

Have updated my comment, only one potential issue remaining but the main ones are solved

@gtm-nayan
Copy link
Contributor

gtm-nayan commented Aug 19, 2023

@ghostdevv Was the last one fixed by #7435 ?

@ghostdevv
Copy link
Member Author

I imagine so, feel free to reopen if I am wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants