Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ACAO: * to static assets in dev #7688

Merged
merged 1 commit into from Nov 16, 2022
Merged

add ACAO: * to static assets in dev #7688

merged 1 commit into from Nov 16, 2022

Conversation

Rich-Harris
Copy link
Member

closes #7664. we might just want to wait for #7543 instead depending on ETA (@benmccann?)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

🦋 Changeset detected

Latest commit: 1ee66c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

@bluwy would probably have a better idea about Vite 4 ETA, but I'm guessing it's a few weeks away

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few weeks is probably a few too long, given that the fix is so small, so if it fixes that in the meantime, we should merge it

@Rich-Harris Rich-Harris merged commit 1663542 into master Nov 16, 2022
@Rich-Harris Rich-Harris deleted the gh-7664 branch November 16, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access-Control-Allow-Origin header is not set on static files in dev mode
3 participants