Skip to content

Commit

Permalink
add ACAO: * to static assets in dev - closes #7664 (#7688)
Browse files Browse the repository at this point in the history
  • Loading branch information
Rich-Harris committed Nov 16, 2022
1 parent 689f6d0 commit 1663542
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/clever-students-report.md
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Add `Access-Control-Allow-Origin: *` to static assets in dev
5 changes: 4 additions & 1 deletion packages/kit/src/exports/vite/dev/index.js
Expand Up @@ -236,7 +236,10 @@ export async function dev(vite, vite_config, svelte_config) {
dev: true,
etag: true,
maxAge: 0,
extensions: []
extensions: [],
setHeaders: (res) => {
res.setHeader('access-control-allow-origin', '*');
}
});

vite.middlewares.use(async (req, res, next) => {
Expand Down
2 changes: 2 additions & 0 deletions packages/kit/test/apps/basics/test/server.test.js
Expand Up @@ -372,6 +372,8 @@ test.describe('Static files', () => {
response = await request.get('/subdirectory/static.json');
expect(await response.json()).toBe('subdirectory file');

expect(response.headers()['access-control-allow-origin']).toBe('*');

response = await request.get('/favicon.ico');
expect(response.status()).toBe(200);
});
Expand Down

0 comments on commit 1663542

Please sign in to comment.