feat: parse spread operators in select queries #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2023
|
LGTM! @soedirgo Any concerns on merging this? |
|
👍 hope this can be merged soon! |
bnjmnt4n
force-pushed
the
spread-operator
branch
from
bcbd0f4
to
1be6b68
Compare
bnjmnt4n
force-pushed
the
spread-operator
branch
from
1be6b68
to
3cacb80
Compare
steve-chavez
approved these changes
Feb 24, 2024
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature.
What is the current behavior?
The
...spread operator is not supported in select queries.What is the new behavior?
The
...spread operator is correctly supported.Additional context
This PR is stacked on top of and should be merged after #496.
Closes #459.
Although there are a couple of existing PRs which implement the same feature, I think this is the most accurate (due to the use of the new
ParseFieldhelper in #496).