refactor: query parser cleanup #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any blockers for this? |
This removes the duplication of parsing required for renamed fields and non-renamed fields.
bnjmnt4n
force-pushed
the
query-parser-cleanup
branch
from
4016952
to
22e0003
Compare
|
@steve-chavez I've rebased this, and will rebase my other PRs as well. |
steve-chavez
approved these changes
Feb 8, 2024
|
@bnjmnt4n Yeah, I'd like to merge those. Could you rebase? |
|
I’ve rebased those as well! |
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
There is a lot of duplicated code in the query parser, due to the field and renamed field parsing sharing the same code.
What is the new behavior?
The parsing of a field is extracted out to a separate
ParseFieldhelper, which can be reused to detect both a renamed field and non-renamed fields. I also updated some comments for accuracy.