Using tagged_iterators for the markup listener
#7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
commented
May 6, 2024
| public const SERVICE_ID = 'sulu_markup.response_listener'; | ||
|
|
||
| /** | ||
| * @deprecated Use the value instead | ||
| */ | ||
| public const TAG_NAME = 'sulu_markup.parser'; |
There was a problem hiding this comment.
Maybe we could move this to the ParserInterface as a constant. Could be helpful for people who use PHP to Configure their app?
mamazu
force-pushed
the
using_tagged_iterators
branch
from
cc2459d
to
738dfae
Compare
mamazu
force-pushed
the
using_tagged_iterators
branch
from
738dfae
to
ff726c6
Compare
mamazu
added
DX
16 tasks
mamazu
force-pushed
the
using_tagged_iterators
branch
from
2047f0f
to
5786b9b
Compare
|
@alexander-schranz This should be BC break free now. We can still remove those classes in 3.0 but that's a different MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Using the tagged iterator concept to reduce the amount of code that sulu has to create.
Why?
See linked issue.
Example Usage
More info on Symfony Tagged Services
To Do