Using Symfony tagged_iterator instead of compiler passes

[mamazu]

Problem description

Currently Sulu reimplements the Symfony DI tagged_iterator functionality for many services. While this is a good idea if you want to have custom logic, this makes no sense in this case. Affected services would be:

• src/Sulu/Component/Symfony/CompilerPass/TaggedServiceCollectorCompilerPass.php (TaggedServiceCollectorCompilerPass -> tagged_iterator #7424)
• MarkupBundle/DependencyInjection/CompilerPass/TagCompilerPass.php
• MarkupBundle/DependencyInjection/CompilerPass/ParserCompilerPass.php (Using tagged_iterators for the markup listener #7403)
• RouteBundle/DependencyInjection/RouteGeneratorCompilerPass.php
• MediaBundle/DependencyInjection/FormatCacheClearerCompilerPass.php
• AdminBundle/DependencyInjection/Compiler/AddAdminPass.php
• MediaBundle/DependencyInjection/ImageTransformationCompilerPass.php
• PageBundle/DependencyInjection/Compiler/StructureExtensionCompilerPass.php
• CoreBundle/DependencyInjection/Compiler/RegisterContentTypesCompilerPass.php
• AdminBundle/DependencyInjection/Compiler/AddMetadataProviderPass.php
• AudienceTargetingBundle/DependencyInjection/Compiler/AddRulesPass.php (Using tagged_iterator for RuleCollections #7405)
• DocumentManagerBundle/DependencyInjection/Compiler/InitializerPass.php
• PageBundle/DependencyInjection/Compiler/SmartContentDataProviderCompilerPass.php
• CoreBundle/DependencyInjection/Compiler/ListBuilderMetadataProviderCompilerPass.php
• SecurityBundle/DependencyInjection/Compiler/AccessControlProviderPass.php
• CoreBundle/DependencyInjection/Compiler/RegisterLocalizationProvidersPass.php

Proposed solution

Use the constructor and call the function from there or make it immutable. So that you can't add services dynamically.

Future ideas

Maybe in the future we could replace this tagging logic with attributes like this:

#[AsLocalizationProvider]
class CustomLocalizationProvider {}

[alexander-schranz]

Would nice if you can extend the issue with a list of services and its releated tags were the Tagged_iterator make sense to discuss if we go with constructor injections or calling the add method.

[mamazu]

Updated it.

[mamazu]

Oddly enough the ListBuilderMetadataProviderCompilerPass configures a service that no longer exists.