Fix jest regression in expect.objectContaining for observable variables #5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will probably be fixed by jestjs/jest#10689, which will probably released today... So maybe we don't need to merge that. |
|
Think I would wait for the fix 🙂 |
This was referenced Oct 27, 2020
Merged
|
Closing this, since we are waiting for the release. Hopefully they release it soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR avoids the usage of
expect.objectContainingin some cases.Why?
Because jestjs/jest#10508 introduced a regression. As soon as
expect.objectContainingis called, it seems like variables passed to it are sometimes changed. For that reason the interceptor on theexcludeGhostsAndShadowsvariables was changed, so theinterceptcall stopped working.