AdminBundle: Add ColorFieldTransformer #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
requested changes
Oct 16, 2020
There was a problem hiding this comment.
@FarouHub Thank you for this PR. We should also add a test for this new transformer see for example IconTransformer.test.js
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Outdated
Show resolved
Hide resolved
… colorFieldTransformer.scss
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Outdated
Show resolved
Hide resolved
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Outdated
Show resolved
Hide resolved
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Show resolved
Hide resolved
...Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/colorFieldTransformer.scss
Outdated
Show resolved
Hide resolved
…Transformers/ColorFieldTransformer.js Co-authored-by: nnatter <niklas.natter@gmail.com>
…Transformers/ColorFieldTransformer.js Co-authored-by: nnatter <niklas.natter@gmail.com>
…Transformers/ColorFieldTransformer.js Co-authored-by: nnatter <niklas.natter@gmail.com>
…Transformers/colorFieldTransformer.scss Co-authored-by: nnatter <niklas.natter@gmail.com>
niklasnatter
approved these changes
Oct 27, 2020
|
The CircleCI error is not related to this PR (see #5569) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add a ColorFieldTransformer form the AdminBundle.
With this transformer we will have the ability to view/show the color choose with the "Color content type" into the admin table list.
Why?
Many users are asking to this option.
Example Usage