Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to set architecture of SDK executable #147

Merged
merged 15 commits into from Apr 19, 2022
Merged

feat: support to set architecture of SDK executable #147

merged 15 commits into from Apr 19, 2022

Conversation

SiongSng
Copy link
Contributor

Close #146

@SiongSng SiongSng changed the title feat: support to set architecture of SDK executable Close #146 feat: support to set architecture of SDK executable Apr 16, 2022
@subosito
Copy link
Owner

Hi @SiongSng, test checks were failed; it would be great if you could fix that.

@SiongSng
Copy link
Contributor Author

Hi @SiongSng, test checks were failed; it would be great if you could fix that.

OK

@SiongSng
Copy link
Contributor Author

SiongSng commented Apr 18, 2022 •
edited

@subosito Please approve the workflow thanks
image

@SiongSng
Copy link
Contributor Author

@subosito Please approve the workflow thanks

@subosito
Copy link
Owner

@SiongSng please revert changes for .github/workflows/workflow.yml so we can focus on the changes themselves. Thanks.

subosito
subosito requested changes Apr 18, 2022
View reviewed changes
Copy link
Owner

@subosito subosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the functionality, I think it's already OK. Now, let's make it prettier and easier to maintain 👍

setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
@SiongSng SiongSng requested a review from subosito April 18, 2022 15:15
@SiongSng SiongSng mentioned this pull request Apr 19, 2022
Closed
@subosito subosito merged commit 6a13bd0 into subosito:main Apr 19, 2022
@jmagman jmagman mentioned this pull request Apr 20, 2022
Merged
4 tasks
@yurikoles yurikoles mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subosito subosito Awaiting requested review from subosito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: can't run flutter on macOS
2 participants
@SiongSng @subosito