Bump GitHub Action versions #387

domesticmouse · 2022-04-16T13:34:45Z

Pre-launch Checklist

I read the Effective Dart: Style recently, and have followed its advice.
I signed the CLA.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

domesticmouse · 2022-04-16T13:58:27Z

Hey @jmagman, any ideas on how to fix the macOS compilation on beta? I've tried installing rosetta, but it looks like I'm holding it wrong.

domesticmouse · 2022-04-17T12:53:56Z

Hey @mit-mit, looks like we have a CI issue with the Dart included in Flutter 2.13.0-0 on GitHub actions for macOS only.

Context: https://github.com/flutter/codelabs/runs/6050738007?check_suite_focus=true#step:5:10

mit-mit · 2022-04-19T14:35:22Z

I tought we were adding ARM64 support, so do we still need Rosetta enabled? cc @cbracken

jmagman · 2022-04-19T20:16:33Z

I tought we were adding ARM64 support, so do we still need Rosetta enabled? cc @cbracken

Yes, flutter tooling still requires Rosetta, in particular when a macOS app builds x64 in release mode on arm64 it uses the x64 version of gen_snapshot.

However that Run dart --version ...: Bad CPU type in executableerror means that the x64 version of dart is being downloaded instead of the arm64 version.

Where is that cache coming from?

domesticmouse · 2022-04-19T22:28:07Z

Hey @jmagman,

If I attempt to enable rosetta on GitHub Actions without an architecture guard it dies, because GitHub Actions is (currently) running on Intel CPUs. I think this PR is worth landing for the future when GitHub gets M1 (or M2) based build bots, but as you can see, adding Rosetta isn't fixing this build failure. So, we need another fix. Halp?

jmagman · 2022-04-19T22:57:57Z

GitHub Actions is (currently) running on Intel CPUs

Oh weird, then maybe it's the opposite, the version of dart being used is arm instead of x64?

mit-mit · 2022-04-20T07:36:34Z

From the CI it's failing with Flutter flutter/2.13.0-0.1.pre-beta/. Looking at https://docs.flutter.dev/development/tools/sdk/releases?tab=macos, that is the first ever release that has both x64 and arm, so I wonder if this is a bug in setup-flutter, that it picks arm when it should be picking x64?

domesticmouse · 2022-04-20T13:16:15Z

@mit-mit whom do we hassle to set up a test to start debugging setup-flutter?

mit-mit · 2022-04-20T13:41:04Z

I think an issue filed here? https://github.com/subosito/flutter-action/issues

jmagman · 2022-04-20T21:03:05Z

They merged this 2 days ago subosito/flutter-action#147

jmagman · 2022-04-20T21:20:34Z

So this would need to be updated

codelabs/.github/workflows/flutter-ci.yml

Line 30 in 8a38fed

- uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8

-  - uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8
+  - uses: subosito/flutter-action@6a13bd08366a2aafe8605f064f9d5a42107e6f1f

jmagman · 2022-04-20T22:35:11Z

.github/workflows/flutter-ci.yml

@@ -30,6 +30,15 @@ jobs:
      - uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8


Suggested change

- uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8

- uses: subosito/flutter-action@6a13bd08366a2aafe8605f064f9d5a42107e6f1f

Hand applied

.github/workflows/flutter-ci.yml

Co-authored-by: Jenn Magder <magder@google.com>

godofredoc · 2022-04-21T00:45:13Z

.github/workflows/flutter-ci.yml

@@ -23,11 +23,12 @@ jobs:
        flutter_version: [stable, beta]
        os: [ubuntu-latest, macos-latest, windows-latest]
    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-java@v1
+      - uses: actions/checkout@v3.0.1


Can we use hashes here? the one for v3.0.1 is dcd71f646680f2efd8db4afa5ad64fdcba30e748

godofredoc · 2022-04-21T00:46:33Z

.github/workflows/flutter-ci.yml

-      - uses: actions/checkout@v2
-      - uses: actions/setup-java@v1
+      - uses: actions/checkout@v3.0.1
+      - uses: actions/setup-java@v3.1.1
        with:


Hash for this version is 9519cf1382ac8dc61ad461f7f7cb45f033220189

godofredoc

We may want to enable dependabot to automate the dependency updates in the future.

domesticmouse · 2022-04-21T00:52:58Z

We may want to enable dependabot to automate the dependency updates in the future.

How do I enable dependabot to update GitHub actions?

parlough · 2022-04-21T01:03:20Z

@domesticmouse Here's how flutter/website does so: https://github.com/flutter/website/blob/main/.github/dependabot.yml#L14-L17

godofredoc · 2022-04-21T01:25:23Z

@domesticmouse Here's how flutter/website does so: https://github.com/flutter/website/blob/main/.github/dependabot.yml#L14-L17

You'll need to create a file in .github/dependabot.yml with lines 1-5 and 14-17.

jmagman · 2022-04-21T01:34:51Z

.github/workflows/flutter-ci.yml

        with:
+          distribution: 'zulu' # See https://github.com/actions/setup-java#supported-distributions


Did you mean to add this?

The distribution is now required for setup-java. There is a choice of java distributions, with zulu being but one. We could alternatively use adopt-hotspot or temurin if that would be more appropriate.

domesticmouse · 2022-04-21T01:49:38Z

@domesticmouse Here's how flutter/website does so: https://github.com/flutter/website/blob/main/.github/dependabot.yml#L14-L17

Added

godofredoc · 2022-04-21T02:06:20Z

.github/dependabot.yaml

+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
  - package-ecosystem: "pub"


I'd also recommend to enable the npm ecosystem for packages-lock.json files in in_app_purchases/. It seems like those files also require multiple updates.

Add rosetta to CI

ba32e84

domesticmouse requested a review from RedBrogdon April 16, 2022 13:34

domesticmouse added 2 commits April 16, 2022 23:48

Update flutter-ci.yml

76c96dd

fix for bash

bbf6dd2

domesticmouse requested a review from jmagman April 16, 2022 13:57

domesticmouse added 2 commits April 19, 2022 16:27

Merge branch 'flutter:master' into install-rosetta

d4dc0c6

Merge branch 'flutter:master' into install-rosetta

428526e

domesticmouse mentioned this pull request Apr 20, 2022

Rebuild tfserving Flutter apps #460

Merged

4 tasks

domesticmouse changed the title ~~Add rosetta to CI~~ Add Rosetta to CI Apr 20, 2022

Try re-setting Xcode

56326d1

jmagman reviewed Apr 20, 2022

View reviewed changes

domesticmouse and others added 2 commits April 21, 2022 10:30

Update .github/workflows/flutter-ci.yml

a807339

Co-authored-by: Jenn Magder <magder@google.com>

Update action versions

d36097f

domesticmouse requested a review from godofredoc April 21, 2022 00:33

domesticmouse changed the title ~~Add Rosetta to CI~~ Bump GitHub Action versions Apr 21, 2022

Merge branch 'flutter:master' into install-rosetta

c222917

godofredoc reviewed Apr 21, 2022

View reviewed changes

Use hashes for versions

58cdbba

godofredoc approved these changes Apr 21, 2022

View reviewed changes

jmagman reviewed Apr 21, 2022

View reviewed changes

Dependabot update GitHub actions

dafa437

godofredoc reviewed Apr 21, 2022

View reviewed changes

domesticmouse merged commit 7cb3b5d into flutter:master Apr 21, 2022

This was referenced Apr 21, 2022

Bump GitHub Actions versions flutter/samples#1115

Merged

subosito/flutter-action@6a13bd08366a2aafe8605f064f9d5a42107e6f1f is not allowed to be used in flutter/codelabs flutter/flutter#102268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump GitHub Action versions #387

Bump GitHub Action versions #387

domesticmouse commented Apr 16, 2022

domesticmouse commented Apr 16, 2022

domesticmouse commented Apr 17, 2022

mit-mit commented Apr 19, 2022

jmagman commented Apr 19, 2022

domesticmouse commented Apr 19, 2022

jmagman commented Apr 19, 2022

mit-mit commented Apr 20, 2022

domesticmouse commented Apr 20, 2022 •

edited

mit-mit commented Apr 20, 2022

jmagman commented Apr 20, 2022

jmagman commented Apr 20, 2022

jmagman Apr 20, 2022

domesticmouse Apr 21, 2022

godofredoc Apr 21, 2022

domesticmouse Apr 21, 2022

godofredoc Apr 21, 2022

domesticmouse Apr 21, 2022

godofredoc left a comment

domesticmouse commented Apr 21, 2022

parlough commented Apr 21, 2022

godofredoc commented Apr 21, 2022

jmagman Apr 21, 2022

domesticmouse Apr 21, 2022

domesticmouse commented Apr 21, 2022

godofredoc Apr 21, 2022

		@@ -30,6 +30,15 @@ jobs:
		- uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8

	- uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8
	- uses: subosito/flutter-action@6a13bd08366a2aafe8605f064f9d5a42107e6f1f

		with:
		distribution: 'zulu' # See https://github.com/actions/setup-java#supported-distributions

Bump GitHub Action versions #387

Bump GitHub Action versions #387

Conversation

domesticmouse commented Apr 16, 2022

Pre-launch Checklist

domesticmouse commented Apr 16, 2022

domesticmouse commented Apr 17, 2022

mit-mit commented Apr 19, 2022

jmagman commented Apr 19, 2022

domesticmouse commented Apr 19, 2022

jmagman commented Apr 19, 2022

mit-mit commented Apr 20, 2022

domesticmouse commented Apr 20, 2022 • edited

mit-mit commented Apr 20, 2022

jmagman commented Apr 20, 2022

jmagman commented Apr 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

godofredoc left a comment

Choose a reason for hiding this comment

domesticmouse commented Apr 21, 2022

parlough commented Apr 21, 2022

godofredoc commented Apr 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domesticmouse commented Apr 21, 2022

Choose a reason for hiding this comment

domesticmouse commented Apr 20, 2022 •

edited