Update cache-key with Runner.os and Arch

[KKimj]

Hello..
This PR will be the last.

How about add ${{ runner.os }} on cache-key ?

Thanks.
Take Care!!

[kuhnroyal]

This looks important :o Do we also need to include the architecture?

[KKimj]

@kuhnroyal
Yeah, I think it would be better that way.
In fact, since there is no arm64 environment at actions, it may feel dubious.

[yurikoles]

Yes, there are no GitHub-hosted arm64 runners now, but one may use a self-hosted one, see #147.

[KKimj]

@yurikoles
Oh.. Sorry.. I missed it.
Thanks you for pointing out it.
In that case, it would be reasonable to introduce arch.

[KKimj]

How about like below?

${{ inputs.cache-key }}-${{ runner.os }}-${{ runner.arch }}-${{ inputs.channel }}-${{ inputs.flutter-version }}

[subosito]

@KKimj Yeah, I think that's better

[kuhnroyal]

Use the ${{ inputs.architecture }}? It seems to have a sane default.

[KKimj]

@kuhnroyal
I agree with you.
I think there is a conner case something like below

• Run on M1, ARM64
• Use x86-64 Flutter SDK, via Rosetta 2

Is it reasonable?
@subosito

[subosito]

I think it's ok, but it would be better if we could set the default by using the existing value given by GitHub runner, like RUNNER_ARCH or runner.arch if possible. What do you think, guys?

[KKimj]

@subosito
It makes sense! Nevertheless, In my opinion, it looks better to maintain.

[KKimj]

As It is an edge case, and without a self-hosting machine, there is no good way to test with github action.

[KKimj]

@subosito
here we go!