Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type declarations for custom message arguments #6354

Merged
merged 3 commits into from Sep 20, 2022
Merged

Fix type declarations for custom message arguments #6354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de5a7e1
Fix the type linting command to actually check the relevant types
stof Sep 19, 2022
1ec2d8e
Fix type declarations for custom message arguments
stof Sep 19, 2022
c192820
Add changelog entry
stof Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-monkeys-return.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"stylelint": patch
---

Fixed: type declarations for custom message arguments
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"noUncheckedIndexedAccess": true,
"esModuleInterop": true,
"resolveJsonModule": true,
"skipLibCheck": true,
stof marked this conversation as resolved.
Show resolved Hide resolved
"skipLibCheck": false,
"typeRoots": ["./types", "./node_modules/@types"]
},
"include": ["lib", "types", "package.json"],
Expand Down
2 changes: 1 addition & 1 deletion types/stylelint/index.d.ts
View file
Open in desktop
Expand Up @@ -353,7 +353,7 @@ declare module 'stylelint' {
ruleName: string;
result: PostcssResult;
message: RuleMessage;
messageArgs?: Parameters<RuleMessage> | undefined;
messageArgs?: Parameters<RuleMessageFunc> | undefined;
node: PostCSS.Node;
/**
* The inclusive start index of the problem, relative to the node's
Expand Down