Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type declarations for custom message arguments #6354

Merged
merged 3 commits into from Sep 20, 2022

Conversation

stof
Copy link
Contributor

@stof stof commented Sep 19, 2022

Which issue, if any, is this issue related to?

Closes #6353

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: c192820

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof Thanks for your first PR contribution. I couldn't notice the type error due to skipLibCheck: true.

I appreciate your report right after the 14.12.0 release. 👍🏼

.changeset/eleven-monkeys-return.md Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
Disabling the checks for lib files will hide typescript errors in the
stylelint type definitions, as those are loaded as a lib type when
type-checking type-test.ts
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

@ybiquitous ybiquitous merged commit b0c49e1 into stylelint:main Sep 20, 2022
@stof stof deleted the fix_types branch September 20, 2022 12:37
@stof
Copy link
Contributor Author

stof commented Sep 20, 2022

@ybiquitous do you have any estimate about when the fix will be released ?

@ybiquitous
Copy link
Member

@stof Perhaps within a few days.

@stof
Copy link
Contributor Author

stof commented Sep 20, 2022

thanks

@ybiquitous
Copy link
Member

14.12.1 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tyep declarations shipped in 14.12.0 are invalid
2 participants