Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex support for ignorePseudoClasses option of selector-pseudo-class-no-unknown #6316

Merged
merged 2 commits into from Sep 3, 2022
Merged

Add regex support for ignorePseudoClasses option of selector-pseudo-class-no-unknown #6316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f333027
Add regex support for `ignorePseudoClasses` option of `selector-pseud…
ybiquitous Sep 2, 2022
f3b078f
Add changelog entry
ybiquitous Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/big-crabs-tap.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"stylelint": minor
---

Added: regex support for `ignorePseudoClasses` option of `selector-pseudo-class-no-unknown`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ask] Is it no problem to consider this PR a minor change? Or a bug fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear-cut. I think minor is fine.

10 changes: 5 additions & 5 deletions lib/rules/selector-pseudo-class-no-unknown/README.md
View file
Open in desktop
Expand Up @@ -58,27 +58,27 @@ input:-moz-placeholder {}

## Optional secondary options

### `ignorePseudoClasses: ["/regex/", "string"]`
### `ignorePseudoClasses: ["/regex/", /regex/, "non-regex"]`

Given:

```json
["/^my-/", "pseudo-class"]
["/^--my-/", "--pseudo-class"]
```

The following patterns are _not_ considered problems:

<!-- prettier-ignore -->
```css
a:pseudo-class {}
a:--my-pseudo {}
```

<!-- prettier-ignore -->
```css
a:my-pseudo {}
a:--my-other-pseudo {}
```

<!-- prettier-ignore -->
```css
a:my-other-pseudo {}
a:--pseudo-class {}
```
2 changes: 1 addition & 1 deletion lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js
View file
Open in desktop
Expand Up @@ -275,7 +275,7 @@ testRule({

testRule({
ruleName,
config: [true, { ignorePseudoClasses: ['unknown', '/^my-/', '/^YOUR-/i'] }],
config: [true, { ignorePseudoClasses: ['unknown', '/^my-/', /^YOUR-/i] }],

accept: [
{
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/selector-pseudo-class-no-unknown/index.js
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ const report = require('../../utils/report');
const ruleMessages = require('../../utils/ruleMessages');
const validateOptions = require('../../utils/validateOptions');
const vendor = require('../../utils/vendor');
const { isString } = require('../../utils/validateTypes');
const { isString, isRegExp } = require('../../utils/validateTypes');
const { isAtRule } = require('../../utils/typeGuards');

const ruleName = 'selector-pseudo-class-no-unknown';
Expand All @@ -41,7 +41,7 @@ const rule = (primary, secondaryOptions) => {
{
actual: secondaryOptions,
possible: {
ignorePseudoClasses: [isString],
ignorePseudoClasses: [isString, isRegExp],
},
optional: true,
},
Expand Down