Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex support for ignorePseudoClasses option of selector-pseudo-class-no-unknown #6316

Merged
merged 2 commits into from Sep 3, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5523

Is there anything in the PR that needs further explanation?

While working on #5523, I notice the selector-pseudo-class-no-unknown rule doesn't support a real regex.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2022

🦋 Changeset detected

Latest commit: f3b078f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

"stylelint": minor
---

Added: regex support for `ignorePseudoClasses` option of `selector-pseudo-class-no-unknown`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ask] Is it no problem to consider this PR a minor change? Or a bug fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear-cut. I think minor is fine.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"stylelint": minor
---

Added: regex support for `ignorePseudoClasses` option of `selector-pseudo-class-no-unknown`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear-cut. I think minor is fine.

@ybiquitous ybiquitous merged commit 68a43cb into main Sep 3, 2022
@ybiquitous ybiquitous deleted the add-support-regex-selector-pseudo-class-no-unknown branch September 3, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants