Fix TypeError for spaceless condition in media-feature-name-value-allowed-list

[lachieh]

Which issue, if any, is this issue related to?

Closes #5577

Is there anything in the PR that needs further explanation?

Following the discussion in the issue, this code implements the changes requested there.

[lachieh]

@ybiquitous @jeddy3 is this really as simple of a change that needs to happen here? Is there a test that can cover this?

[hudochenkov]

@lachieh you could use an example from the issue and add it to the tests for the rule.

[ybiquitous]

@lachieh

As @hudochenkov suggested, it would be helpful to have a test case. 😃

In addition, it would be helpful if you would improve our custom type for postcss-media-query-parser like this:

-		nodes: Child[];
+		nodes?: Child[];

stylelint/types/postcss-media-query-parser/index.d.ts

Line 10 in 585d28a

nodes: Child[];

[lachieh]

Thank you, both. Test case will go in the accepts, right? Since it doesn't trigger the error, we're just checking that it doesn't bomb?

[ybiquitous]

@lachieh Yes!

[jeddy3]

@lachieh Thanks for the pull request. If you haven't already seen it, there are steps in the CONTRIBUTING guide to run the test runner on just a particular rule. Once you've added a test case (and made @ybiquitous suggested change), we can trigger the workflow for you.

[lachieh]

The definition has been updated and the test case added. Thanks!

[hudochenkov]

@lachieh there is TypeScript error in some other rule, because types were changed. Could you fix it? Otherwise we can help to fix it.

[lachieh]

@hudochenkov surely can! I'll be back at my desk in about 24 hours.

[ybiquitous]

Oh, my suggested type change occurred the type error on lib/rules/no-duplicate-at-import-rules/index.js. 😅

It seem OK to fall back to [] as below:

 			// extract media queries if any
-			const media = mediaParser(valueParser.stringify(restParams))
-				.nodes.map((n) => n.value.replace(/\s/g, ''))
+			const media = (mediaParser(valueParser.stringify(restParams)).nodes || [])
+				.map((n) => n.value.replace(/\s/g, ''))
 				.filter((n) => n.length);

[lachieh]

All done! Thanks everyone!

[ybiquitous]

@lachieh Thanks! LGTM 😄

[jeddy3]

LGTM, thanks!

v14 changelog entry added:

• Fixed: media-feature-name-value-allowed-list TypeError for spaceless condition (#5581).