Fix TypeError for spaceless condition in media-feature-name-value-all…

…owed-list (#5581) * update rule to exit early if parsing is not possible * change type to indicate optional nodes property * add test to cover invalid media rule * update code for rule after updating types
stylelint · Oct 12, 2021 · a413527 · a413527
1 parent 816b19a
commit a413527
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/lib/rules/media-feature-name-allowed-list/__tests__/index.js b/lib/rules/media-feature-name-allowed-list/__tests__/index.js
@@ -39,6 +39,9 @@ testRule({
 		{
 			code: '@media (color) { }',
 		},
+		{
+			code: '@media only screen and(min-width: 640px) { }',
+		},
 	],
 
 	reject: [

diff --git a/lib/rules/media-feature-name-value-allowed-list/index.js b/lib/rules/media-feature-name-value-allowed-list/index.js
@@ -31,6 +31,8 @@ const rule = (primary) => {
 
 		root.walkAtRules(/^media$/i, (atRule) => {
 			mediaParser(atRule.params).walk(/^media-feature-expression$/i, (node) => {
+				if (!node.nodes) return;
+
 				const mediaFeatureRangeContext = isRangeContextMediaFeature(node.parent.value);
 
 				// Ignore boolean

diff --git a/lib/rules/no-duplicate-at-import-rules/index.js b/lib/rules/no-duplicate-at-import-rules/index.js
@@ -38,8 +38,8 @@ const rule = (primary) => {
 					: firstParam.value;
 
 			// extract media queries if any
-			const media = mediaParser(valueParser.stringify(restParams))
-				.nodes.map((n) => n.value.replace(/\s/g, ''))
+			const media = (mediaParser(valueParser.stringify(restParams)).nodes || [])
+				.map((n) => n.value.replace(/\s/g, ''))
 				.filter((n) => n.length);
 
 			const isDuplicate = media.length

diff --git a/types/postcss-media-query-parser/index.d.ts b/types/postcss-media-query-parser/index.d.ts
@@ -7,7 +7,7 @@ declare module 'postcss-media-query-parser' {
 		after: string;
 		before: string;
 		sourceIndex: number;
-		nodes: Child[];
+		nodes?: Child[];
 		walk: Walker;
 	};