Fix false negatives for grid shorthands in named-grid-areas-no-invalid #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
reviewed
Sep 5, 2021
There was a problem hiding this comment.
@jeddy3 Thank you for creating the PR. I've left some refactoring suggestions, but it looks almost fine! 😄
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Thanks for the review and suggestions. I've committed them both. |
|
My suggestion code seems to be something wrong. 👀 |
|
By the change of indentation (80f5ab3), it is necessary to change the expectation of diff --git a/lib/rules/named-grid-areas-no-invalid/__tests__/index.js b/lib/rules/named-grid-areas-no-invalid/__tests__/index.js
index e49bc06d..4855c7fd 100644
--- a/lib/rules/named-grid-areas-no-invalid/__tests__/index.js
+++ b/lib/rules/named-grid-areas-no-invalid/__tests__/index.js
@@ -117,7 +117,7 @@ testRule({
}`,
message: messages.expectedToken(),
line: 2,
- column: 4,
+ column: 2,
},
{
code: 'a { grid-template-areas: "" "" ""; }', |
ybiquitous
approved these changes
Sep 6, 2021
|
No worries at all! I appreciate the review 😄 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5513 (review)
gridandgrid-template.