Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-hex-alpha rule #5316

Merged
merged 3 commits into from May 29, 2021
Merged

Add color-hex-alpha rule #5316

merged 3 commits into from May 29, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented May 19, 2021

Which issue, if any, is this issue related to?

Closes #4891
Closes #4880

Is there anything in the PR that needs further explanation?

Implements the remaining requested changes in #4891.

Most of the tests were failing, so refactored to tidy things up and fixed the bugs.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some trivial comments, but it looks good to me. 👍🏼

lib/rules/color-hex-alpha/README.md Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 jeddy3 merged commit ea107d7 into v14 May 29, 2021
@jeddy3 jeddy3 deleted the add-color-hex-alpha branch May 29, 2021 08:21
@jeddy3
Copy link
Member Author

jeddy3 commented May 29, 2021

  • Added: color-hex-alpha rule (#5316).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants