Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color-hex-alpha rule #4891

Closed
wants to merge 21 commits into from
Closed

Add color-hex-alpha rule #4891

wants to merge 21 commits into from

Conversation

ssivanatarajan
Copy link
Contributor

@ssivanatarajan ssivanatarajan commented Aug 8, 2020 •
edited

Which issue, if any, is this issue related to?

Have added a new rule as discussed in issue #4880.

Is there anything in the PR that needs further explanation?

No need

@ssivanatarajan ssivanatarajan changed the title Added color-hex-alpha rule Add color-hex-alpha rule Aug 8, 2020
jeddy3
jeddy3 requested changes Aug 9, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssivanatarajan Thanks for the pull request. It's looking good.

I've requested some changes.

Can you also add the rule to the list in the docs, please?

lib/rules/color-hex-alpha/__tests__/index.js Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js Show resolved Hide resolved
ssivanatarajan and others added 8 commits August 10, 2020 22:50
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
76a225b 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
b010bd3 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
91cd023 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/__tests__/index.js
af7f37e 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
added more testRules
0bfd429
Merge branch 'master' of https://github.com/ssivanatarajan/stylelint
f011132
lint errors
0f203b3
lint fix
2ba2852
@ssivanatarajan
Copy link
Contributor Author

@jeddy3 Made the changes Please review it.

ssivanatarajan
ssivanatarajan commented Aug 14, 2020
View reviewed changes
Copy link
Contributor Author

@ssivanatarajan ssivanatarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Made the changes

@ssivanatarajan
Copy link
Contributor Author

@jeddy3 can u please review this PR

@ssivanatarajan
Copy link
Contributor Author

@jeddy3 any update on this ?

@ssivanatarajan
Copy link
Contributor Author

@ssivanatarajan Thanks for the pull request. It's looking good.

I've requested some changes.

Can you also add the rule to the list in the docs, please?

added

@ssivanatarajan
Copy link
Contributor Author

@jeddy3 is anything that needs to be changed /reviewed?

jeddy3
jeddy3 requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

I've looked through the PR again and requested some more changes.

lib/rules/color-hex-alpha/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js
code: 'a { color: #{ff}; }',
description: 'scss interpolation',
},
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an accept test for:

$var: #fff;

And a reject test for:

$var: #fffa;

The latter will likely fail until the if (!isStandardSyntaxDeclaration(decl)) return; conditional is removed.

lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js
if (!validOptions) return;

root.walkDecls((decl) => {
if (!isStandardSyntaxDeclaration(decl)) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this as per #5010 (comment).

lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/color-hex-alpha/index.js Outdated Show resolved Hide resolved
ssivanatarajan and others added 7 commits January 4, 2021 08:08
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/__tests__/index.js
74aef39 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/__tests__/index.js
f49a000 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/__tests__/index.js
e1a7c9c 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
ed97deb 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
ba285ac 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
c65de4b 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/__tests__/index.js
ad47041 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
ssivanatarajan and others added 2 commits January 4, 2021 18:46
@ssivanatarajan @jeddy3
Update lib/rules/color-hex-alpha/index.js
845d19f 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
PR fixes
401e676
@jeddy3 jeddy3 mentioned this pull request May 19, 2021
Merged
@jeddy3
Copy link
Member

jeddy3 commented May 29, 2021

Finished in #5316

@jeddy3 jeddy3 closed this May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ssivanatarajan @jeddy3