Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignoreContextFunctionalPseudoClasses to selector-max-id #4835

Merged
merged 7 commits into from Jun 22, 2020
Merged

Add ignoreContextFunctionalPseudoClasses to selector-max-id #4835

merged 7 commits into from Jun 22, 2020

Commits on Jun 19, 2020

  1. implement 'failing' tests 

    these tests aren't failing properly, am I missing something?
    @mattxwang
    mattxwang committed Jun 19, 2020
    Copy the full SHA
    cf8205e View commit details
    Browse the repository at this point in the history

  2. stub functionality 

    this has the same functionality as live
    @mattxwang
    mattxwang committed Jun 19, 2020
    Copy the full SHA
    24875fa View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. adjusting tests for currently-supported pseduo classes, implements logic

    @mattxwang
    mattxwang committed Jun 20, 2020
    Copy the full SHA
    2936ce2 View commit details
    Browse the repository at this point in the history

  2. adds documentation for new option

    @mattxwang
    mattxwang committed Jun 20, 2020
    Copy the full SHA
    25e910a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Mostly focused on conciseness

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 20, 2020
    Copy the full SHA
    915ac82 View commit details
    Browse the repository at this point in the history

  4. Update lib/rules/selector-max-id/README.md 

    Consistency w/ other READMEs (will be changed later)

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 20, 2020
    Copy the full SHA
    38c75a5 View commit details
    Browse the repository at this point in the history

  5. minor style change

    @mattxwang
    mattxwang committed Jun 20, 2020
    Copy the full SHA
    d1c87f4 View commit details
    Browse the repository at this point in the history