Add ignoreContextFunctionalPseudoClasses to selector-max-id #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests aren't failing properly, am I missing something?
this has the same functionality as live
|
Looks like the coveralls code coverage testing is failing on a |
|
I restarted the tests and they're all 👍 this time. Must have been a temporary gremlin. |
jeddy3
requested changes
Jun 20, 2020
There was a problem hiding this comment.
@malsf21 Looking good, thanks!
I've requested some minor changes as suggestions. Mainly to align with our conventions, e.g.:
- the minimum amount of code possible to communicate the pattern, e.g. if the rule targets selectors then use an empty rule, e.g.
{}
Let's use Given: and just an array for now in the example so that it's consistent with the READMEs of the other rules. There's an issue (#4808) to update these across the board to use the full config in the examples.
Mostly focused on conciseness Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
|
Great, thank you for the feedback; batch-committed everything in the code review! |
jeddy3
requested changes
Jun 20, 2020
Consistency w/ other READMEs (will be changed later) Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
|
Sounds good, updated! |
|
Updated changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR implements an option requested in #4619, the verbose
ignoreContextFunctionalPseudoClassestoselector-max-id. In addition to modifying the rule, it also introduces a set of simple test cases (only testing on:not,:has, and:matchescurrently), and adds documentation to explain the usage of the rule.Closes #4619.
As mentioned in the issue discussion, it looks like
stylelint/lib/utils/isLogicalCombination.jsneeds to be updated to support more pseudo-classes, such as:isand:where(and possibly:nth-child); will follow up on this!