Fix false positives for WebExtension replacement keywords in value-keyword-case #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ two basic tests
jeddy3
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a PR that aims to address #4707, by adding a regex match to
isStandardSyntaxValuethat ignores values of the form/__MSG_[^\s]+__/, a set of runtime values often used by browsers for internationalization (more information here, as mentioned in the issue discussion). I also added two tests, one that checks for the positive, and one that checks for case-sensitivity.As
value-keyword-caseusesisStandardSyntaxValue, this should resolve the false positive originally brought up in the issue.Locally, this PR passes
npm run formatandnpm run test.Closes #4707.
Not on my end! Let me know if I should change the comments or add more tests.